part of cam6_3_016: support for nuopc threading#348
Merged
fvitt merged 2 commits intoESCOMP:cam_developmentfrom Apr 1, 2021
Merged
part of cam6_3_016: support for nuopc threading#348fvitt merged 2 commits intoESCOMP:cam_developmentfrom
fvitt merged 2 commits intoESCOMP:cam_developmentfrom
Conversation
cacraigucar
approved these changes
Mar 29, 2021
Collaborator
So if you don't like it, it is "old and crusty"? ;) Seriously, this module is going away in the new infrastructure. |
nusbaume
approved these changes
Mar 29, 2021
gold2718
requested changes
Mar 29, 2021
Collaborator
gold2718
left a comment
gold2718
left a comment
There was a problem hiding this comment.
This PR still needs a ChangeLog entry and an issue describing the problem this is addressing.
cacraigucar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a port for CMEPS threading in CAM. The change in physics_types.F90 is due to a stack size issue in the call to flush. It could also be solved via an OMP master region, but I think that that call in the code is really old and crusty and no longer required.
Fixes issue #349